Skip to content

feat: telemetry when using quick create #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

feat: telemetry when using quick create #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/common/telemetry/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
export enum EventNames {
EXTENSION_ACTIVATION_DURATION = "EXTENSION.ACTIVATION_DURATION",
EXTENSION_MANAGER_REGISTRATION_DURATION = "EXTENSION.MANAGER_REGISTRATION_DURATION",
EXTENSION_ACTIVATION_DURATION = 'EXTENSION.ACTIVATION_DURATION',
EXTENSION_MANAGER_REGISTRATION_DURATION = 'EXTENSION.MANAGER_REGISTRATION_DURATION',

ENVIRONMENT_MANAGER_REGISTERED = "ENVIRONMENT_MANAGER.REGISTERED",
PACKAGE_MANAGER_REGISTERED = "PACKAGE_MANAGER.REGISTERED",
ENVIRONMENT_MANAGER_REGISTERED = 'ENVIRONMENT_MANAGER.REGISTERED',
PACKAGE_MANAGER_REGISTERED = 'PACKAGE_MANAGER.REGISTERED',

VENV_USING_UV = "VENV.USING_UV",
VENV_USING_UV = 'VENV.USING_UV',
VENV_CREATION = 'VENV.CREATION',
}

// Map all events to their properties
Expand Down Expand Up @@ -45,4 +46,13 @@ export interface IEventNamePropertyMapping {
"venv.using_uv": {"owner": "karthiknadig" }
*/
[EventNames.VENV_USING_UV]: never | undefined;

/* __GDPR__
"venv.creation": {
"creationType": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "owner": "karthiknadig" }
}
*/
[EventNames.VENV_CREATION]: {
creationType: 'quick' | 'custom';
};
}
5 changes: 5 additions & 0 deletions src/managers/builtin/venvUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ import { showErrorMessage } from '../../common/errors/utils';
import { Common, VenvManagerStrings } from '../../common/localize';
import { isUvInstalled, runUV, runPython } from './helpers';
import { getProjectInstallable, getWorkspacePackagesToInstall } from './pipUtils';
import { sendTelemetryEvent } from '../../common/telemetry/sender';
import { EventNames } from '../../common/telemetry/constants';

export const VENV_WORKSPACE_KEY = `${ENVS_EXTENSION_ID}:venv:WORKSPACE_SELECTED`;
export const VENV_GLOBAL_KEY = `${ENVS_EXTENSION_ID}:venv:GLOBAL_SELECTED`;
Expand Down Expand Up @@ -462,6 +464,7 @@ export async function createPythonVenv(
if (customize === undefined) {
return;
} else if (customize === false) {
sendTelemetryEvent(EventNames.VENV_CREATION, undefined, { creationType: 'quick' });
const installables = await getProjectInstallable(api, project ? [project] : undefined);
return await createWithProgress(
nativeFinder,
Expand All @@ -473,6 +476,8 @@ export async function createPythonVenv(
path.join(venvRoot.fsPath, '.venv'),
installables?.flatMap((i) => i.args ?? []),
);
} else {
sendTelemetryEvent(EventNames.VENV_CREATION, undefined, { creationType: 'custom' });
}

const basePython = await pickEnvironmentFrom(sortedEnvs);
Expand Down