fix: wrap the experimental shell type API with try-catch #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
added
the
bug
There was a problem hiding this comment.
PR Overview
This pull request wraps the experimental shell type API in a try-catch block to handle potential runtime errors during shell detection.
- Wraps the code within fromShellTypeApi() in a try-catch block
- Returns TerminalShellType.unknown upon encountering an error
Changes
| File | Description |
|---|---|
| src/features/common/shellDetector.ts | Wraps shell type API code in try-catch |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
Tyriar
approved these changes
Feb 10, 2025
NguyenCuong1989
referenced
this pull request
in NguyenCuong1989/vscode-python-environments
Oct 23, 2025
fixes microsoft/vscode-python-environments#159 We need to wrap the API in a try-catch block to handle any potential errors that might occur as it is currently being worked on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #159
We need to wrap the API in a try-catch block to handle any potential errors that might occur as it is currently being worked on.