Skip to content

Conversation

@karthiknadig
Copy link
Member

No description provided.

@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Jan 17, 2025
@karthiknadig karthiknadig requested a review from Copilot January 17, 2025 20:05
@karthiknadig karthiknadig self-assigned this Jan 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • examples/sample1/src/api.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

src/features/terminal/utils.ts:7

  • The function waitForShellIntegration should be covered by tests to ensure it handles the polling and timeout correctly.
export async function waitForShellIntegration(terminal: Terminal): Promise<boolean> {

src/extension.ts:232

  • The new behavior introduced by the initialize method call for the terminalManager should be covered by tests.
await terminalManager.initialize();

Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more

@karthiknadig karthiknadig marked this pull request as ready for review January 20, 2025 13:56
@vs-code-engineering
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Jan 20, 2025
@karthiknadig karthiknadig merged commit d3f07a9 into microsoft:main Jan 21, 2025
6 checks passed
@karthiknadig karthiknadig deleted the terminal1 branch January 21, 2025 16:06
NguyenCuong1989 referenced this pull request in NguyenCuong1989/vscode-python-environments Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants