Skip to content

Quote conda env remove arguments when using full path #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Quote conda env remove arguments when using full path #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/managers/conda/condaUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import { CondaStrings } from '../../common/localize';
import { showErrorMessage } from '../../common/errors/utils';
import { showInputBox, showQuickPick, withProgress } from '../../common/window.apis';
import { Installable, selectFromCommonPackagesToInstall } from '../common/pickers';
import { quoteArgs } from '../../features/execution/execUtils';

export const CONDA_PATH_KEY = `${ENVS_EXTENSION_ID}:conda:CONDA_PATH`;
export const CONDA_PREFIXES_KEY = `${ENVS_EXTENSION_ID}:conda:CONDA_PREFIXES`;
Expand Down Expand Up @@ -585,7 +586,7 @@ async function createPrefixCondaEnvironment(
}

export async function deleteCondaEnvironment(environment: PythonEnvironment, log: LogOutputChannel): Promise<boolean> {
let args = ['env', 'remove', '--yes', '--prefix', environment.environmentPath.fsPath];
let args = quoteArgs(['env', 'remove', '--yes', '--prefix', environment.environmentPath.fsPath]);
return await withProgress(
{
location: ProgressLocation.Notification,
Expand Down
Loading