Skip to content

register 'execute commands' onto Project Manager#531

Merged
Eskibear merged 4 commits into
microsoft:masterfrom
Eskibear:run-goals
Aug 31, 2020
Merged

register 'execute commands' onto Project Manager#531
Eskibear merged 4 commits into
microsoft:masterfrom
Eskibear:run-goals

Conversation

@Eskibear
Copy link
Copy Markdown
Member

@Eskibear Eskibear commented Aug 26, 2020

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear Eskibear requested a review from jdneo August 26, 2020 08:25
@Eskibear
Copy link
Copy Markdown
Member Author

Note that the wording "execute commands..." here might be not clear enough.
In Maven extension, the full name of the command (in command palette) is "Maven: execute commands...", because the group is "Maven".

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@jdneo
Copy link
Copy Markdown
Member

jdneo commented Aug 26, 2020

Will you consider change it to Execute Maven Commands...? IMO, trigger the command from Maven & Project explorer may be more frequency than in command palette.

@Eskibear
Copy link
Copy Markdown
Member Author

Then the side effect would be "Maven: Execute Maven Commands..." in command palette. And yes it's OK for me.

@jdneo
Copy link
Copy Markdown
Member

jdneo commented Aug 27, 2020

So now we have three possible solution per offline discussion:

  • Change to Maven: Execute Maven Commands...
  • Wrap another command for tree view usage
  • Open a ticket to VS Code about adding a treeview display name for a command

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Copy Markdown
Member Author

Now using an alias command maven.goal.execute.fromProjectManager for the same functionality.

image

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear Eskibear merged commit 50b7ff8 into microsoft:master Aug 31, 2020
@Eskibear Eskibear deleted the run-goals branch August 31, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants