Merge pull request #191 from MODUSCarstenScholling/dev-164-alerts

#164 Allow common [!ANY] alerts
microsoft · Oct 29, 2024 · 9d31cad · 9d31cad
2 parents 955d899 + 73ad4d5
commit 9d31cad
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/languageFeatures/documentLinks.ts b/src/languageFeatures/documentLinks.ts
@@ -176,8 +176,8 @@ const referenceLinkPattern = new RegExp(
 
 	/**/r`|` +
 
-	// [shorthand]
-	/****/r`\[\s*(?<shorthand>(?:\\.|[^\[\]\\])+?)\s*\]` +
+	// [shorthand] but not [!shorthand]
+	/****/r`\[(?!\!)\s*(?<shorthand>(?:\\.|[^\[\]\\])+?)\s*\]` +
 	r`)` +
 	r`(?![\(])`,  // Must not be followed by a paren to avoid matching normal links
 	'gm');
@@ -816,4 +816,3 @@ export function createWorkspaceLinkCache(
 	const linkComputer = new MdLinkComputer(parser, workspace);
 	return new MdWorkspaceInfoCache(workspace, (doc, token) => linkComputer.getAllLinks(doc, token));
 }
-
diff --git a/src/test/documentLinks.test.ts b/src/test/documentLinks.test.ts
@@ -255,6 +255,14 @@ suite('Link computer', () => {
 		]);
 	});
 
+	test('Should not find reference link shorthand when prefixed with ! (#164)', async () => {
+		const links = await getLinksForText(joinLines(
+			'[!note]',
+			'[!anything]',
+		));
+		assertLinksEqual(links, []);
+	});
+
 	test('Should find reference link with space in reference name', async () => {
 		const links = await getLinksForText(joinLines(
 			'[text][my ref]',