Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Enter in native notebooks should put cell into command mode immediately, then run the cell. #6583

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

joyceerhl
Copy link
Contributor

For #6582

@joyceerhl joyceerhl requested a review from a team as a code owner July 8, 2021 07:07
@codecov-commenter
Copy link

Codecov Report

Merging #6583 (5030c7c) into main (14d5a86) will increase coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##            main   #6583    +/-   ##
======================================
  Coverage     69%     69%            
======================================
  Files        410     410            
  Lines      28240   28240            
  Branches    4196    4196            
======================================
+ Hits       19588   19702   +114     
+ Misses      6991    6866   -125     
- Partials    1661    1672    +11     
Impacted Files Coverage Δ
...rc/client/datascience/commands/notebookCommands.ts 62% <0%> (ø)
src/client/common/process/pythonDaemonPool.ts 75% <0%> (-5%) ⬇️
...ience/kernel-launcher/localKernelSpecFinderBase.ts 80% <0%> (-3%) ⬇️
.../datascience/notebook/notebookControllerManager.ts 79% <0%> (-3%) ⬇️
...rc/client/datascience/jupyter/debuggerVariables.ts 78% <0%> (-2%) ⬇️
src/client/datascience/baseJupyterSession.ts 68% <0%> (-1%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 76% <0%> (-1%) ⬇️
...active-common/intellisense/intellisenseProvider.ts 74% <0%> (-1%) ⬇️
...t/datascience/notebook/vscodeNotebookController.ts 80% <0%> (+<1%) ⬆️
src/client/datascience/commands/commandRegistry.ts 40% <0%> (+<1%) ⬆️
... and 14 more

@joyceerhl joyceerhl merged commit d04d36f into main Jul 8, 2021
@joyceerhl joyceerhl deleted the dev/joyceerhl/ctrl-enter branch July 8, 2021 23:01
@joyceerhl joyceerhl linked an issue Jul 10, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+Enter should go to Control mode immediately
3 participants