Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for script files in nested directories #15457

Merged
merged 3 commits into from
Apr 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ suite('ipywidget - CDN', () => {
config: {
'js-logger': 'https://unpkg.com/js-logger/src/logger.min'
}
},
{
file: '@finos/perspective-jupyterlab',
config: {
'@finos/perspective-jupyterlab': 'nbextensions/@finos/perspective-jupyterlab/index'
}
}
].forEach((item) => {
test(`Extract require.js configuration mapping for ${item.file}`, async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class LocalIPyWidgetScriptManager extends BaseIPyWidgetScriptManager impl

// Get all of the widget entry points, which would be of the form `nbextensions/<widget folder>/extension.js`
const nbExtensionsFolder = Uri.joinPath(nbExtensionsParentPath, 'nbextensions');
const extensions = await this.fs.searchLocal('*/extension.js', nbExtensionsFolder.fsPath, true);
const extensions = await this.fs.searchLocal('**/extension.js', nbExtensionsFolder.fsPath, true);
return extensions.map((entry) => ({
uri: Uri.joinPath(nbExtensionsFolder, entry),
widgetFolderName: path.dirname(entry)
Expand Down

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Loading