Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cookies and passwords and hub (3) #13592

Closed
wants to merge 3 commits into from

Conversation

DonJayamanne
Copy link
Contributor

Part of #12832

  • Remove code for Jupyter hub (it has not worked for 2 years, and its completely broken)
  • If a 3rd party is providing a Jupyter server, the expectation is that will give the necessary auth headers
  • hence the feature of supporting password protected Jupyter Server uris is very specific to user provided uris
    • That's not a generic feature, its a standalone feature
    • Thus cookies, passwords, etc all go out of generic jupyter/kernel code/layers.
    • Now we ONLY handle headers, previously we would inject cookies, xsrf, headers, base urls, baseToken in number of places and different ways, all very complicated and unnecessary. All replaced with headers

@DonJayamanne DonJayamanne deleted the rightHubPasswordRefactor branch September 4, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant