Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cookies and passwords and hub (3) (old) #13574

Closed
wants to merge 3 commits into from

Conversation

DonJayamanne
Copy link
Contributor

Part of #12832

  • Remove code for Jupyter hub (it has not worked for 2 years, and its completely broken)
  • If a 3rd party is providing a Jupyter server, the expectation is that will give the necessary auth headers
  • hence the feature of supporting password protected Jupyter Server uris is very specific to user provided uris
    • That's not a generic feature, its a standalone feature
    • Thus cookies, passwords, etc all go out of generic jupyter/kernel code/layers.
    • Now we ONLY handle headers, previously we would inject cookies, xsrf, headers, base urls, baseToken in number of places and different ways, all very complicated and unnecessary. All replaced with headers

@DonJayamanne DonJayamanne force-pushed the removeCookiesAndPasswordsAndHub branch 2 times, most recently from db8e486 to ada1459 Compare May 27, 2023 12:35
@DonJayamanne DonJayamanne changed the title Remove cookies and passwords and hub Remove cookies and passwords and hub (3) May 28, 2023
@DonJayamanne DonJayamanne force-pushed the removeCookiesAndPasswordsAndHub branch from 2247e24 to 6c8d001 Compare May 29, 2023 23:10
@DonJayamanne DonJayamanne force-pushed the removeCookiesAndPasswordsAndHub branch from 6c8d001 to 986ded7 Compare May 30, 2023 00:18
@DonJayamanne DonJayamanne changed the title Remove cookies and passwords and hub (3) Remove cookies and passwords and hub (3) (old) May 30, 2023
@DonJayamanne DonJayamanne deleted the removeCookiesAndPasswordsAndHub branch June 25, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant