Skip to content

Commit

Permalink
Search for script files in nested directories (#15457)
Browse files Browse the repository at this point in the history
* Search for script files in nested directories

* Add script files

* oops
  • Loading branch information
DonJayamanne authored Apr 1, 2024
1 parent f257c4b commit 16bab35
Show file tree
Hide file tree
Showing 6 changed files with 715 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ suite('ipywidget - CDN', () => {
config: {
'js-logger': 'https://unpkg.com/js-logger/src/logger.min'
}
},
{
file: '@finos/perspective-jupyterlab',
config: {
'@finos/perspective-jupyterlab': 'nbextensions/@finos/perspective-jupyterlab/index'
}
}
].forEach((item) => {
test(`Extract require.js configuration mapping for ${item.file}`, async () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class LocalIPyWidgetScriptManager extends BaseIPyWidgetScriptManager impl

// Get all of the widget entry points, which would be of the form `nbextensions/<widget folder>/extension.js`
const nbExtensionsFolder = Uri.joinPath(nbExtensionsParentPath, 'nbextensions');
const extensions = await this.fs.searchLocal('*/extension.js', nbExtensionsFolder.fsPath, true);
const extensions = await this.fs.searchLocal('**/extension.js', nbExtensionsFolder.fsPath, true);
return extensions.map((entry) => ({
uri: Uri.joinPath(nbExtensionsFolder, entry),
widgetFolderName: path.dirname(entry)
Expand Down

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

0 comments on commit 16bab35

Please sign in to comment.