Fix/jest scenarios #219
Merged
Fix/jest scenarios #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously removing this would prevent source maps getting resolved at runtime at all.
I noticed in profiles that this was actually a bottleneck for Jest tests (in #214) when running as a cluster. I wanted to use a worker thread for it, but it looks like there's an issue in vscode preventing that[1] for the moment. This cuts the time-to-first-breakpoint in half for the jest tests, which is fairly nice. The child process is killed after 30 seconds of inactivity. I may do an algorithmic optimization pass on the hash in the future. In particular, Node/V8 now has native bigint support, which is almost certainly faster than the `long` library. 1. microsoft/vscode#88386
roblourens
approved these changes
Jan 10, 2020
EricCornelson
approved these changes
Jan 10, 2020
|
|
||
| const send = (req: HashRequest): Promise<string | undefined> => { | ||
| const cp = create(); | ||
| cleanup(); |
There was a problem hiding this comment.
Does this call just start the 30s timer for the cleanup callback? It's not totally clear from the name alone.
There was a problem hiding this comment.
Yep, debouce will call the wrapped function 30 seconds after the last call to it. More explanation on debouncing
There was a problem hiding this comment.
Got it. I'm familiar with debouncing, it just wasn't clear that calling cleanup() wasn't actually executing the cleanup method, but rather starting the debounce timer for the cleanup method.
There was a problem hiding this comment.
Ah, gotcha, I'll clarify that variable name on master!
connor4312
force-pushed
the
fix/jest-scenarios
branch
from
8e7cdc3
to
85f2154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: preserve source map handler even without pauses
Previously removing this would prevent source maps getting resolved at runtime at all.
fix: disable instrumentation bp in node by default
It looks like in Jest the instrumentation BP is set, but because everything is on disk and we have the manually added entrypoint breakpoints, this is not needed.
feat: move content hashing to a child process
I noticed in profiles that this was actually a bottleneck for Jest tests
(in Should it debug typescript files ? #214) when running as a cluster. I wanted to use a worker thread
for it, but it looks like there's an issue in vscode preventing that[1]
for the moment.
This cuts the time-to-first-breakpoint in half for the jest tests, which
is fairly nice. The child process is killed after 30 seconds of
inactivity. I may do an algorithmic optimization pass on the hash in
the future. In particular, Node/V8 now has native bigint support, which
is almost certainly faster than the
longlibrary.Fixes #214