Skip to content

chore: Clean up the metadata files #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdneo merged 2 commits into from
Jun 7, 2022
Merged

chore: Clean up the metadata files #622

jdneo merged 2 commits into from
Jun 7, 2022

Conversation

@jdneo
Copy link
Member

@jdneo jdneo commented Jun 6, 2022

Signed-off-by: sheche [email protected]

@jdneo jdneo added the eng engineering label Jun 6, 2022
@jdneo jdneo added this to the 0.20.0 milestone Jun 6, 2022
@jdneo jdneo requested a review from CsCherrYY June 6, 2022 05:40
@jdneo
Copy link
Member Author

jdneo commented Jun 6, 2022

Looks like some cases are failed after the metadata file is removed:

 1) Simple Project View Tests
       Can node render correctly:
	at done (/home/runner/work/vscode-java-dependency/vscode-java-dependency/node_modules/mocha/lib/mocha.js:1058:7)
AssertionError [ERR_ASSERTION]: Project name should be "1.helloworld"
+ expected- actual
	at processTicksAndRejections (node:internal/process/task_queues:96:5)
-simple_d4700ecf
+1.helloworld

will take a look.

@jdneo jdneo marked this pull request as draft June 6, 2022 05:48
@CsCherrYY
Copy link
Contributor

CsCherrYY commented Jun 6, 2022

how about using some assertion like assertTrue(project.getName().contains('simple')) for invisible projects

@jdneo
Copy link
Member Author

jdneo commented Jun 6, 2022

how about using some assertion like assertTrue(project.getName().contains('simple')) for invisible projects

That's a good idea. I just realized that maybe the original test is used to test Eclipse project? So I should not remove the metadata files?

@jdneo jdneo marked this pull request as ready for review June 7, 2022 02:28
@jdneo jdneo merged commit ac162da into main Jun 7, 2022
@jdneo jdneo deleted the cs/metadata branch June 7, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CsCherrYY CsCherrYY CsCherrYY approved these changes

Assignees

No one assigned

Labels

eng engineering

Projects

None yet

Milestone

0.20.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jdneo @CsCherrYY