-
Notifications
You must be signed in to change notification settings - Fork 82
Support exporting jar with custom task #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
d907db0
Support custom task to export jar
CsCherrYY 90061e8
Update ExportJarTaskProvider.ts
CsCherrYY b3376b4
Address part of the comments (WIP)
CsCherrYY 234e3cf
Address the comments
CsCherrYY 69f1266
Rename interface IClassPath
CsCherrYY bdd2bf5
Update GenerateJarExecutor.ts
CsCherrYY abb7d7a
Address the comments
CsCherrYY add912f
Address part of the comments(WIP)
CsCherrYY 700dfe7
Address the comments
CsCherrYY 85a88a8
Address the comments
CsCherrYY 4310c7a
Address the comments
CsCherrYY 1230000
Merge branch 'master' into CustomTask
CsCherrYY e48e59a
Address the comments
CsCherrYY f1764b1
Merge branch 'master' into CustomTask
CsCherrYY 41961a6
Apply changes
CsCherrYY d20d77a
Improve the wording
CsCherrYY af14f5b
Tune naming and add some comments
CsCherrYY 2d6d1fa
Shorten code length
CsCherrYY 8600742
tune wording and error handing
CsCherrYY File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reference about how to support intellisense for constant literals when configuring elements.
https://github.com/microsoft/vscode-java-debug/blob/master/package.json#L346-L373
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@testforstephen beautiful!