Skip to content

Use folder name as the name of the invisible project #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdneo merged 2 commits into from
Aug 25, 2020
Merged

Use folder name as the name of the invisible project #312

jdneo merged 2 commits into from
Aug 25, 2020

Conversation

@jdneo
Copy link
Member

@jdneo jdneo commented Aug 24, 2020

image

@jdneo jdneo added this to the 0.13.0 milestone Aug 24, 2020
@jdneo jdneo closed this Aug 24, 2020
@jdneo jdneo reopened this Aug 24, 2020
testforstephen
testforstephen reviewed Aug 24, 2020
View reviewed changes
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/model/PackageNode.java Outdated
}

public String getDisplayName() {
return displayName;
Copy link
Contributor

@testforstephen testforstephen Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return displayName || name;

@jdneo jdneo merged commit ea43694 into master Aug 25, 2020
@jdneo jdneo deleted the cs/invisible-name branch August 25, 2020 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@testforstephen testforstephen testforstephen approved these changes

@Eskibear Eskibear Awaiting requested review from Eskibear

@CsCherrYY CsCherrYY Awaiting requested review from CsCherrYY

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.13.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jdneo @testforstephen