Skip to content

Rename the extension to 'Project Manager for Java' #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jdneo merged 1 commit into from
Jul 7, 2020
Merged

Rename the extension to 'Project Manager for Java' #274

jdneo merged 1 commit into from
Jul 7, 2020

Conversation

@jdneo
Copy link
Member

@jdneo jdneo commented Jul 6, 2020 •
edited
Loading

fix #248

@jdneo
Copy link
Member Author

jdneo commented Jul 6, 2020

One problem:

The explorer: Maven Projects & Java Projects somehow duplicated in name.

image

@akaroml @testforstephen @Eskibear @CsCherrYY Any idea?

@Eskibear
Copy link
Member

Eskibear commented Jul 6, 2020

Simply rename "Maven Projects" to "Maven" ?

@jdneo
Copy link
Member Author

jdneo commented Jul 7, 2020

Simply rename "Maven Projects" to "Maven" ?

+1.

@jdneo jdneo added this to the 0.11.0 milestone Jul 7, 2020
@jdneo jdneo marked this pull request as ready for review July 7, 2020 05:02
@jdneo jdneo requested a review from akaroml July 7, 2020 05:02
@Eskibear Eskibear mentioned this pull request Jul 7, 2020
Merged
akaroml
akaroml approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@akaroml akaroml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jdneo jdneo merged commit 1a9ba5e into master Jul 7, 2020
@jdneo jdneo deleted the cs/issue-248 branch July 7, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akaroml akaroml akaroml approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.11.0

Development

Successfully merging this pull request may close these issues.

Rename Extension to 'Project Manager for Java'

4 participants

@jdneo @Eskibear @akaroml