Migrate icons to codicon in dependency explorer #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaroml
requested changes
Mar 13, 2020
Member
akaroml
left a comment
akaroml
left a comment
There was a problem hiding this comment.
One major goal of this change is to use themes. So we need to prioritize for real meanings, and then the image.
src/views/containerNode.ts
Outdated
| protected get iconPath(): { light: string, dark: string } { | ||
| return ExplorerNode.resolveIconPath("library"); | ||
| protected get iconPath(): ThemeIcon { | ||
| return new ThemeIcon("inbox"); |
Member
There was a problem hiding this comment.
We are actually looking for "books" right? But it's not there. How about " files"?
Member
There was a problem hiding this comment.
Can we request books in vscode repo?
src/views/packageNode.ts
Outdated
| protected get iconPath(): { light: string; dark: string } { | ||
| return ExplorerNode.resolveIconPath("package"); | ||
| protected get iconPath(): ThemeIcon { | ||
| return new ThemeIcon("symbol-namespace"); |
Member
There was a problem hiding this comment.
I would suggest "symbol-package".
src/views/packageRootNode.ts
Outdated
| const data = <IPackageRootNodeData>this.nodeData; | ||
| if (data.entryKind === PackageRootKind.K_BINARY) { | ||
| return ExplorerNode.resolveIconPath("jar"); | ||
| return new ThemeIcon("archive"); |
Member
Author
|
Now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #246
This PR is to totally migrate the icons in dependency explorer to
codicon.Before:
After:
@testforstephen @akaroml @Eskibear Please take a look when you have time, let me know if this UI change is acceptable or if you have any suggestions.
Reference: https://microsoft.github.io/vscode-codicons/dist/codicon.html