Fix the sync issue with non-java files, resolvePath for non-java file… #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… should not return an empty path Signed-off-by: andxu <[email protected]>
Contributor
Author
yaohaizh
reviewed
Nov 16, 2018
| PackageNode packageNode = new PackageNode(packageName, packageFragment.getPath().toPortableString(), NodeKind.PACKAGE); | ||
| IPackageFragmentRoot pkgRoot = (IPackageFragmentRoot) packageFragment.getParent(); | ||
| PackageNode rootNode = null; | ||
| if (typeRoot instanceof IClassFile) { |
Contributor
There was a problem hiding this comment.
typeRoot is already null...
yaohaizh
reviewed
Nov 16, 2018
| pkgRoot.getPath().toPortableString(), NodeKind.PACKAGEROOT, pkgRoot.getKind()); | ||
| } | ||
|
|
||
| IProject proj = parentJavaElement.getJavaProject().getProject(); |
Contributor
There was a problem hiding this comment.
This part should be duplicate code
yaohaizh
reviewed
Nov 16, 2018
| return result; | ||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Misleading method name. Should be ancestor list
yaohaizh
reviewed
Nov 16, 2018
|
|
||
| private static List<PackageNode> getParentListToProject(IResource element) throws JavaModelException { | ||
| List<PackageNode> nodeList = new ArrayList<>(); | ||
| while (element != null) { |
Contributor
There was a problem hiding this comment.
This part have lots of duplicate code with other parts in this file
This was referenced Nov 16, 2018
Contributor
Author
|
using #131 to replace this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… should not return an empty path
Signed-off-by: andxu [email protected]