This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fixed wrong workspace when one gopath is the substring of another. #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath in “canonicalizeGOPATHPrefix” of “util.ts”.
|
Hi @potterdai, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
ramya-rao-a
reviewed
Nov 29, 2016
| @@ -98,12 +98,17 @@ export function canonicalizeGOPATHPrefix(filename: string): string { | |||
| if (!gopath) return filename; | |||
| let workspaces = gopath.split(path.delimiter); | |||
| let filenameLowercase = filename.toLowerCase(); | |||
|
|
|||
There was a problem hiding this comment.
Can you add a comment here about the logic being used, so that the next person knows whats going on?
The unit tests are failing in travis due to linting issues. Run npm run lint locally and fix the reported errors.
- Fixed CI complaints about linting issues
ramya-rao-a
approved these changes
Nov 29, 2016
|
Thanks @potterdai ! Will merge as soon as all the tests pass. |
|
The latest update 0.6.51 has this fix. |
mattetti
added a commit
to mattetti/vscode-go
that referenced
this pull request
Jan 11, 2017
* 'master' of github.com:mattetti/vscode-go: (128 commits) Add telemetry support for the Go extension Add dlv path to error msg when dlv not found Fixes microsoft#465 outline offset problem in No-English language (microsoft#699) fix coverage display when editor changes to undefined (microsoft#693) Add support for reading http.proxy setting (microsoft#639) Fixing flaky unit tests Refactor for corner cases Reduce noise in console log due to errors from hover Changelog for next update 0.6.51 Remove space after brackets in snippet as per microsoft#628 Fixes microsoft#647 Strip version from autocompleted pkgs from gopkg.in (microsoft#659) Fixes microsoft#647 Support vendor pkgs from root of GOPATH/src (microsoft#660) Fixes microsoft#640 Use spawn to handle big data from gocode (microsoft#661) Fixed wrong workspace when one gopath is the substring of another. (microsoft#658) Fix "gotests" when generates test for current function for type methods (microsoft#657) Add benchmark function snippet (microsoft#648) Fix "Go to Definition" when running Go HEAD (microsoft#655) Fixes microsoft#642 Only add -d once to formatflags (microsoft#644) Updating Changelog and package.json for 0.6.50 update Log errors to console ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrong workspace when one gopath is the substring of another in “canonicalizeGOPATHPrefix” of “util.ts”.