launch.json env option to display numbers as hex while debugging #1801

valerino · 2018-07-22T20:41:08Z

wonder why this was missing.......

…as hex together with the decimal value (i.e. 10 is displayed as 0x0a (10))

in launch.json: ... "env": { // controls numbers display while debugging // "hex" (shows hex only) "hexdec" ( shows hex (dec) ) // default: shows dec only "DBG_SHOW_NUMBERS_HEX": "hexdec" }, ...

msftclas · 2018-07-23T18:13:15Z

All CLA requirements met.

…HEAD

ramya-rao-a · 2018-08-01T00:40:52Z

Can you elaborate on some examples where this will be useful?
Is the need for this Golang specific or a generic requirement?
Is this a common enough requirement or a very special case?

valerino · 2018-08-04T10:29:33Z

hi ramya,
well..... in a debugger, you should be able to display int values as hex.
for example, i'm developing a computer emulator in golang (commodore 64 emulator) and in this situation having hex values displayed while debugging is vital.
but well...... this is not the only case, i mean ..... just to display a buffer in memory while debugging, without relying to printf, and so on ..... there should be no debugger without 'show as hex' as an option imho.

jhendrixMSFT

There have been times I've wanted this functionality (e.g. being able to view ACSII characters for structs marshalled to JSON), needs some clean-up before we can merge though.

jhendrixMSFT · 2019-01-10T21:48:08Z

src/debugAdapter/goDebug.ts

@@ -519,6 +517,19 @@ class GoDebugSession extends DebugSession {
 		if (/^(\w:[\\/]|\\\\)/.test(path)) return '\\';
 		return path.includes('/') ? '/' : '\\';
 	}
+	protected convertToHex(v) {


Sig should be private convertToHex(v: string): string. Also missing a new-line character between 519 and 520.

jhendrixMSFT · 2019-01-10T21:49:13Z

src/debugAdapter/goDebug.ts

 			return {
 				result: v.value || ('<' + v.type + '>'),
+				variablesReference: this._variableHandles.create(v)


This is incorrect and will cause boolean types to display like they have child elements. It should remain variablesReference: v.children.length > 0 ? this._variableHandles.create(v) : 0 like below which means the two clauses can be refactored.

jhendrixMSFT · 2019-01-10T21:50:28Z

src/debugAdapter/goDebug.ts

+			};
+		} else {
+			return {
+				result: this.convertToHex(v.value) || ('<' + v.type + '>'),


For types v.value will be an empty string, so convertToHex() needs to handle this case and return an empty string (with the current implementation you get 0xNaN in the variables window).

jhendrixMSFT · 2019-01-10T22:10:08Z

src/debugAdapter/goDebug.ts

+	protected convertToHex(v) {
+		let s = v;
+		if (this.numAsHex === 'hex') {
+			s = '0x' + parseInt(v).toString(16);


This will truncate floating-point numbers. Perhaps this functionality should be limited to integers?

jhendrixMSFT · 2019-01-11T21:28:00Z

Related microsoft/vscode#28025

ramya-rao-a · 2019-01-15T03:36:59Z

@jhendrixMSFT Does microsoft/vscode#28025 (comment) work for Go?

jhendrixMSFT · 2019-01-15T21:54:24Z

@ramya-rao-a no it doesn't work, would be great to fix it.

marco-m-pix4d · 2019-08-06T13:30:51Z

Hello, is this PR still valid?

ramya-rao-a · 2020-05-20T06:43:21Z

Closing this PR as it has not seen any activity after the review by @jhendrixMSFT last year #1801 (review)

If anyone is interested in reviving this PR, please create a new one in https://github.com/golang/vscode-go as we are moving the repo for this extension.

while debugging, primitive types (i.e. int, uint, ...) are displayed …

7a701ce

…as hex together with the decimal value (i.e. 10 is displayed as 0x0a (10))

valerino changed the title ~~while debugging, primitive types (i.e. int, uint, ...) are displayed …~~ while debugging, primitive types (i.e. int, uint, ...) are displayed as hex together with the decimal value (i.e. 10 is displayed as 0x0a (10)) Jul 22, 2018

valerino and others added 3 commits July 22, 2018 22:56

fixed indentation

6d29324

Show err ms when package not found

d2579a5

introduced launch.json option, no more hardcoding

2725d1c

in launch.json: ... "env": { // controls numbers display while debugging // "hex" (shows hex only) "hexdec" ( shows hex (dec) ) // default: shows dec only "DBG_SHOW_NUMBERS_HEX": "hexdec" }, ...

valerino added 5 commits July 23, 2018 20:25

fixed previous commit

8357368

goDebug.ts should be correct now

c04c08b

forgot to declare member

0ad9cac

fixed indentation

badfcdd

fixed for linter

66e43c7

valerino changed the title ~~while debugging, primitive types (i.e. int, uint, ...) are displayed as hex together with the decimal value (i.e. 10 is displayed as 0x0a (10))~~ launch.json env option to display numbers as hex while debugging Jul 23, 2018

valerino added 2 commits July 24, 2018 21:50

Merge https://github.com/microsoft/vscode-go

e89cdbb

debugger wasn't starting after last fixes

83c54b7

ramya-rao-a force-pushed the master branch from d2579a5 to a3033f4 Compare July 25, 2018 00:50

valerino added 3 commits July 30, 2018 21:08

updated

e8b84ea

Merge branch 'master' of https://github.com/microsoft/vscode-go into …

57c84f3

…HEAD

Merge branch 'tmp'

4a9dbf2

valerino added 5 commits August 4, 2018 12:32

Merge branch 'master' of https://github.com/microsoft/vscode-go

467a288

added 'hexascii' to show hex value together with ascii value

d5cfce6

booleans were not handled correctly

ec4ade2

fixed indentation

9c45da1

fixed missing semicolon

d782002

ramya-rao-a force-pushed the master branch from d711046 to dfc1682 Compare August 8, 2018 21:59

jhendrixMSFT suggested changes Jan 10, 2019

View reviewed changes

ramya-rao-a added the debug label Jan 28, 2020

ramya-rao-a closed this May 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

launch.json env option to display numbers as hex while debugging #1801

launch.json env option to display numbers as hex while debugging #1801

valerino commented Jul 22, 2018 •

edited

Loading

msftclas commented Jul 23, 2018 •

edited

Loading

ramya-rao-a commented Aug 1, 2018

valerino commented Aug 4, 2018 •

edited

Loading

jhendrixMSFT left a comment

jhendrixMSFT Jan 10, 2019

jhendrixMSFT Jan 10, 2019

jhendrixMSFT Jan 10, 2019

jhendrixMSFT Jan 10, 2019

jhendrixMSFT commented Jan 11, 2019

ramya-rao-a commented Jan 15, 2019

jhendrixMSFT commented Jan 15, 2019

marco-m-pix4d commented Aug 6, 2019

ramya-rao-a commented May 20, 2020

launch.json env option to display numbers as hex while debugging #1801

launch.json env option to display numbers as hex while debugging #1801

Conversation

valerino commented Jul 22, 2018 • edited Loading

msftclas commented Jul 23, 2018 • edited Loading

ramya-rao-a commented Aug 1, 2018

valerino commented Aug 4, 2018 • edited Loading

jhendrixMSFT left a comment

Choose a reason for hiding this comment

jhendrixMSFT Jan 10, 2019

Choose a reason for hiding this comment

jhendrixMSFT Jan 10, 2019

Choose a reason for hiding this comment

jhendrixMSFT Jan 10, 2019

Choose a reason for hiding this comment

jhendrixMSFT Jan 10, 2019

Choose a reason for hiding this comment

jhendrixMSFT commented Jan 11, 2019

ramya-rao-a commented Jan 15, 2019

jhendrixMSFT commented Jan 15, 2019

marco-m-pix4d commented Aug 6, 2019

ramya-rao-a commented May 20, 2020

valerino commented Jul 22, 2018 •

edited

Loading

msftclas commented Jul 23, 2018 •

edited

Loading

valerino commented Aug 4, 2018 •

edited

Loading