Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve properties capture for the sendErrorData method #191

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Improve properties capture for the sendErrorData method #191

merged 1 commit into from
Nov 22, 2023

Commits on Nov 13, 2023

  1. Improve properties capture for an error event 

    `sender.sendErrorData` doesn't always receive data object with a properties
field. In the case of unhandled errors vscode itself calls this with all the
properties being in the top level of the `data` argument. This PR accounts for
that and fallbacks to using full data object if a properties field doesn't exist
    @ilia-db
    ilia-db committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    493e811 View commit details
    Browse the repository at this point in the history