Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pipeline #68

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Add pipeline #68

merged 3 commits into from
Oct 12, 2022

Conversation

rzhao271
Copy link
Contributor

Some parts I changed that I'm not sure of are the testSteps and the pr sections.

@rzhao271 rzhao271 added this to the October 2022 milestone Oct 11, 2022
@rzhao271 rzhao271 requested a review from lszomoru October 11, 2022 16:38
@rzhao271 rzhao271 self-assigned this Oct 11, 2022
lszomoru
lszomoru reviewed Oct 11, 2022
View reviewed changes
build/pipeline.yml Outdated Show resolved Hide resolved
lszomoru
lszomoru reviewed Oct 11, 2022
View reviewed changes
build/pipeline.yml Outdated Show resolved Hide resolved
lszomoru
lszomoru requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@lszomoru lszomoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only some minor tweaks to make.

@rzhao271 rzhao271 requested a review from lszomoru October 11, 2022 18:13
lszomoru
lszomoru previously approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@lszomoru lszomoru left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rzhao271, can you please update the .npmignore file to exclude the build folder. 🚀

@rzhao271 rzhao271 requested a review from lszomoru October 11, 2022 23:30
@lszomoru lszomoru merged commit 07203e5 into main Oct 12, 2022
@lszomoru lszomoru deleted the rzhao271/pipeline branch October 12, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lszomoru lszomoru lszomoru approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
October 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@rzhao271 @lszomoru