Fixes Issue 117154 - VScode Emmet missing HTML "hgroup" tag #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rzhao271
reviewed
Mar 1, 2021
src/test/expand.test.ts
Outdated
| @@ -119,6 +119,9 @@ describe('Expand Abbreviations', () => { | |||
| // https://github.com/microsoft/vscode/issues/114923 | |||
| testExpandWithCompletion('html', 'figcaption', '<figcaption>${0}</figcaption>'); | |||
|
|
|||
| // https://github.com/microsoft/vscode/issues/117154 | |||
There was a problem hiding this comment.
Nitpick: can you move this addition to a later part of the document? The tests are currently somewhat sorted by issue id
rzhao271
approved these changes
Mar 2, 2021
|
Thanks! merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds suggestion for the
hgrouptag in vscode-emmet-helper.Fixes Issue #117154.