Adding ability to parse an abbreviation and then expanding it. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jens1o
reviewed
Feb 15, 2018
| @@ -626,17 +626,20 @@ function applyVendorPrefixes(expandedProperty: string, vendors: string, preferen | |||
| return prefixedProperty + expandedProperty; | |||
| } | |||
|
|
|||
| export function parseAbbreviation(abbreviation: string, options: ExpandOptions): any { | |||
| return parse(abbreviation, options); | |||
| } | |||
|
|
|||
| /** | |||
| * Expands given abbreviation using given options | |||
| * @param abbreviation string | |||
There was a problem hiding this comment.
this needs to be adjusted, doesn't it?
There was a problem hiding this comment.
No, the type isn't string anymore.
There was a problem hiding this comment.
Edit: I was looking at the wrong place. You're right, we set the parameter to any and line 635 should reflect that.
The parse function in the expand module is expecting an abbreviation of type string.
The idea is that, having an abbreviation that is a string, you can either:
- Expand it as usual, or
- Parse it into a tree structure with this method, then read/modify it, and finally expand it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emmetio/expand-abbreviation module allows to parse an abbreviation and get a tree structure out of it, which can later be passed as argument to the expand method.
Adding the ability to do this when using the emmet-helper.