Adding vendor prefixes to css abbreviations #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
suggested changes
Jan 26, 2018
| // Fix for https://github.com/Microsoft/vscode/issues/28933#issuecomment-309236902 | ||
| // When user types in propertyname, emmet uses it to match with snippet names, resulting in width -> widows or font-family -> font: family | ||
| // Filter out those cases here. | ||
| const abbrRegex = new RegExp('.*' + abbreviation.split('').map(x => x === '$' ? '\\$' : x).join('.*') + '.*', 'i'); | ||
| let abbreviationWithoutDashPrefix = abbreviation[0] == '-' ? abbreviation.slice(1) : abbreviation; |
There was a problem hiding this comment.
This is only applicable for css abbreviations. So I'd suggest to have a another function vendorPrefixCssAbbreviation that takes in abbreviation and syntax and returns a boolean. You can use isStylesheet to check the syntax as well as look for the preceeding -.
Re-use this function inside expandAbbreviationWithDash
- rename this function as
expandCssAbreviationWithVendorPrefixes - have a check on the syntax. Use the
isStylesheetfunction.
Also rename expandAbbreviationWithDash to expandCssAbbreviationWithVendorPrefix
ramya-rao-a
reviewed
Jan 26, 2018
src/emmetHelper.ts
Outdated
| @@ -525,10 +525,10 @@ export function getExpandOptions(syntax: string, emmetConfig?: object, filter?: | |||
| }; | |||
| } | |||
|
|
|||
| export function expandAbbreviationWithDash(abbreviation: string, options: any) { | |||
| export function expandCSSAbbreviationWithVendorPrefixes(abbreviation: string, options: any) { | |||
There was a problem hiding this comment.
- no need to export this function
- rename (again, sorry!) to just
expandCSSAbbreviation
ramya-rao-a
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified so that when preceding a CSS abbreviation with a dash, it gets expanded with all the vendor-prefixes.
For example,
-bdrd10gets expanded to