Add secutity tips for the html preview #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
commented
Mar 20, 2017
|
|
||
| `vscode.previewHtml` - Render the html of the resource in an editor view. | ||
|
|
||
| Links contained in the document will be handled by VS Code whereby it supports `file`-resources and [virtual](https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L3295)-resources as well as triggering commands using the `command`-scheme. Use the query part of a command-uri to pass along JSON-encoded arguments - note that URL-encoding must be applied. |
Contributor
Author
There was a problem hiding this comment.
This section all lives in a comment right now. I'm in favor of consolidating it all under the new html preview section in the docs
mjbvz
added a commit
to microsoft/vscode
that referenced
this pull request
Mar 22, 2017
Follow up on: microsoft/vscode-docs#896 Removes the extended documentation for the html preview since this now lives in the vscode docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the Html preview docs out to its own section of the API complex commands documentation. Also adds notes on html preview security as part of microsoft/vscode#22103