Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify extensions don't sync for remote #7322

Merged
merged 1 commit into from
May 28, 2024

Conversation

ntrogh
Copy link
Contributor

@ntrogh ntrogh commented May 28, 2024

Related to #7319

@ntrogh ntrogh marked this pull request as ready for review May 28, 2024 11:16
@vscodenpa vscodenpa added this to the May 2024 milestone May 28, 2024
@ntrogh ntrogh merged commit 5693072 into microsoft:main May 28, 2024
2 checks passed
@ntrogh ntrogh deleted the settings-sync-fix branch May 28, 2024 11:34
@@ -352,3 +352,9 @@ The Marketplace also provides you with resources to make an informed decision ab
* **Issues, Repository, and License** - Check if the publisher has provided these and if they have the support you expect.

If you do see an extension that looks suspicious, you can report the extension to the Marketplace with the **Report Abuse** link at the bottom of the extension **More Info** section.

### My extensions don't synchronize when connected to a remote window
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not say "remote" and not "remote window", to keep the terminology in the rest of the docs e.g. https://code.visualstudio.com/docs/remote/remote-overview?

I realize the text further below specifies this better, but I have not seen the term "remote window" used anywhere else. Just "remote".

(Same comment in the body of the text below, if you find this applicable, and in all other doc changes in this change)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. There are a few instances where we mention remote window and it's also mentioned in the hover text in VS Code. I acknowledge that we don't clearly define the terminology and use it consistently (for example, we also have occurrences of "remote context"). I'll create a follow-up issue to review our docs. Thanks for pointing this out, @thernstig!

image

Copy link
Contributor

@thernstig thernstig May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting @ntrogh! I had not contemplated that Remote Window part. I wonder if that text should also in reality say just "Remote". The window is always "local" in the way I see it.

You are the the expert in this area though, so I have no better input on if "Remote Window" makes sense in some cases or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a subtle one. We need to aim for consistency and clarity, so there's no confusion. I'll take it up with the team and definitely also appreciate your input. Keep it coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants