Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelog, version, NOTICE.html #1940

Merged
merged 4 commits into from
May 5, 2020
Merged

Update changelog, version, NOTICE.html #1940

merged 4 commits into from
May 5, 2020

Conversation

bwateratmsft
Copy link
Collaborator

No description provided.

@bwateratmsft bwateratmsft added this to the 1.2.0 milestone May 5, 2020
@bwateratmsft bwateratmsft requested a review from a team as a code owner May 5, 2020 13:57
@bwateratmsft bwateratmsft self-assigned this May 5, 2020
rcjsuen
rcjsuen reviewed May 5, 2020
View reviewed changes
Copy link
Contributor

@rcjsuen rcjsuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth mentioning that 1.2.0 depends on Visual Studio Code 1.44? Or perhaps this should be something on the README.md file?

CHANGELOG.md Show resolved Hide resolved
@bwateratmsft
Copy link
Collaborator Author

Is it worth mentioning that 1.2.0 depends on Visual Studio Code 1.44? Or perhaps this should be something on the README.md file?

@rcjsuen Can't hurt! Though by the time we ship, probably about 95% will be upgraded.

@bwateratmsft bwateratmsft changed the title Update changelog and version Update changelog, version, NOTICE.html May 5, 2020
@bwateratmsft bwateratmsft merged commit 24b2554 into master May 5, 2020
@bwateratmsft bwateratmsft deleted the bmw/1.2.0 branch May 5, 2020 19:47
@bwateratmsft bwateratmsft removed their assignment May 5, 2020
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
@bwateratmsft @Dmarch28
Update changelog, version, NOTICE.html (microsoft#1940)
31e0684
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcjsuen rcjsuen rcjsuen left review comments

@karolz-ms karolz-ms karolz-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bwateratmsft @karolz-ms @rcjsuen