Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Add categories to metadata #740

Merged
merged 8 commits into from
Feb 9, 2021
Merged

Add categories to metadata #740

merged 8 commits into from
Feb 9, 2021

Conversation

Chuxel
Copy link
Member

@Chuxel Chuxel commented Feb 5, 2021

Also includes (Community) in descriptions for those not created by MS or core extension engineering teams.

@2percentsilk
Copy link
Member

@Chuxel this looks good! Do we have anything we're waiting on for merging or can I go ahead?

Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding these changes! I think adding the "Community" signifiers at a top-level makes sense. I also see based on the template that any new definitions would by default be Community but cannot be Core.

@egamma
Copy link
Member

egamma commented Feb 8, 2021

@Chuxel LGTM.

Just an observation, there are some gaps/inconsistencies when it comes to DB coverage.

mongo:

  • javascript-node-mongo - category: core
  • typescript-node-mongo - does not exist

postgres:

  • python-3-postgres - category: core
  • javascript-node-postgres - category: community
  • typescript-node-postgres - does not exist

@Chuxel
Copy link
Member Author

Chuxel commented Feb 9, 2021

Just an observation, there are some gaps/inconsistencies when it comes to DB coverage.

mongo:

javascript-node-mongo - category: core
typescript-node-mongo - does not exist

postgres:

python-3-postgres - category: core
javascript-node-postgres - category: community
typescript-node-postgres - does not exist

@egamma Yeah javascript-node-postgres was contributed by the community, so that is accurate. We could consider "adopting" it. For the typescript ones, I'm currently hesitant to add additional non-community maintained definitions given the volume we have already. Let's discuss.

@Chuxel Chuxel merged commit a9ab215 into master Feb 9, 2021
@Chuxel Chuxel deleted the clantz/categories branch February 21, 2021 01:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants