Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge for 1.23.3 (pre-release) #13136

Merged
merged 25 commits into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
fa80d44
Support for copilot-generated summaries in quick info. (On-the-fly do…
spebl Dec 9, 2024
d04d53e
Detect compile_commands.json after containing folder deleted and recr…
yiftahw Dec 11, 2024
cd5aaaa
Fix native strings. (#13046)
sean-mcmanus Dec 12, 2024
ab7bebf
Fix space around binary operator translation. (#13057)
sean-mcmanus Dec 14, 2024
d7ee241
Update `extension.test.ts` reference (#13040)
emmanuel-ferdman Dec 14, 2024
fbf8135
Trigger reparsing when `files.encoding` setting changes (#13047)
Colengms Dec 16, 2024
afb208d
get isense client by uri (#13059)
lukka Dec 17, 2024
84b92dc
Don't show the output window for "references may be missing" when the…
bobbrow Dec 18, 2024
b11f390
Bump nanoid from 3.3.7 to 3.3.8 in /Extension (#13060)
dependabot[bot] Dec 18, 2024
73f4442
Update the descriptions of clang path settings (#13071)
bobbrow Dec 19, 2024
b96d82a
Add appName telemetry (#13072)
benmcmorran Dec 19, 2024
5c684a8
Don't reset everyones databases (#13073)
Colengms Dec 19, 2024
a172a42
Ensure default persistent values get persisted (#13074)
Colengms Dec 19, 2024
0aaae1f
Support sending telemetry during cpptools initialization (#13077)
benmcmorran Dec 20, 2024
2bff033
Handle multiple compile commands on client side (needs native server …
yiftahw Dec 30, 2024
42c6d99
Updated Description for Preferred Path Separator Setting and Refactor…
browntarik Dec 31, 2024
d2626e0
Re-enable the SingleRootProject tests with check-in tests and fix the…
sean-mcmanus Dec 31, 2024
fa0e1c0
Fix cl.exe.not.available loc. (#13091)
sean-mcmanus Dec 31, 2024
d70d063
Fix other developer command prompt cases, and "developer" and "code" …
sean-mcmanus Jan 2, 2025
6e3e074
Update msvc versions. (#13097)
sean-mcmanus Jan 3, 2025
4c6f319
Update IntelliSense loc strings. (#13098)
sean-mcmanus Jan 3, 2025
200f093
Add 3rd party notice for libiconv (#13056)
Colengms Jan 7, 2025
8e5bbf1
Support C89 in Completion Prompts (#13132)
kuchungmsft Jan 8, 2025
205ae06
Update changelog and version for 1.23.3. (#13127)
sean-mcmanus Jan 8, 2025
941aa60
Minor TPN updates. (#13135)
sean-mcmanus Jan 8, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/job-compile-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@ jobs:
run: yarn test
working-directory: Extension

# These tests don't require the binary.
# On Linux, it is failing (before the tests actually run) with: Test run terminated with signal SIGSEGV.
# But it works on Linux during the E2E test.
- name: Run SingleRootProject tests
if: ${{ inputs.platform != 'linux' }}
run: yarn test --scenario=SingleRootProject --skipCheckBinaries
working-directory: Extension

# NOTE : We can't run the test that require the native binary files
# yet -- there will be an update soon that allows the tester to
# acquire them on-the-fly
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* [Build and debug the extension](Documentation/Building%20the%20Extension.md).
* File an [issue](https://github.com/Microsoft/vscode-cpptools/issues) and a [pull request](https://github.com/Microsoft/vscode-cpptools/pulls) with the change and we will review it.
* If the change affects functionality, add a line describing the change to [**CHANGELOG.md**](Extension/CHANGELOG.md).
* Try and add a test in [**test/extension.test.ts**](Extension/test/unitTests/extension.test.ts).
* Try and add a test in [**test/extension.test.ts**](Extension/test/scenarios/SingleRootProject/tests/extension.test.ts).
* Run tests via opening the [**Extension**](https://github.com/Microsoft/vscode-cpptools/tree/main/Extension) folder in Visual Studio Code, selecting the "Launch Tests" configuration in the Debug pane, and choosing "Start Debugging".

## About the Code
Expand Down
11 changes: 0 additions & 11 deletions Extension/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,6 @@ module.exports = {
"eslint-plugin-header"
],
"rules": {
"indent": [
"warn",
4,
{
"SwitchCase": 1,
"ObjectExpression": "first"
}
],
"@typescript-eslint/indent": [
"error", 4
],
"@typescript-eslint/adjacent-overload-signatures": "error",
"@typescript-eslint/array-type": "error",
"@typescript-eslint/await-thenable": "error",
Expand Down
3 changes: 3 additions & 0 deletions Extension/.scripts/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,9 @@ export async function checkDTS() {
}

export async function checkBinaries() {
if ($switches.includes('--skipCheckBinaries')) {
return false;
}
let failing = false;
failing = !await assertAnyFile(['bin/cpptools.exe', 'bin/cpptools']) && (quiet || warn(`The native binary files are not present. You should either build or install the native binaries\n\n.`)) || failing;

Expand Down
29 changes: 29 additions & 0 deletions Extension/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,33 @@
# C/C++ for Visual Studio Code Changelog

## Version 1.23.3: January 9, 2025
### New Feature
* Enable setting multiple compile commands. [#7029](https://github.com/microsoft/vscode-cpptools/issues/7029)
* Thank you for the contribution. [@yiftahw](https://github.com/yiftahw) [PR #12960](https://github.com/microsoft/vscode-cpptools/pull/12960)

### Enhancements
* Modifications to the snippet completions to more closely match the snippets provided by TypeScript. [#4482](https://github.com/microsoft/vscode-cpptools/issues/4482)
* Update clang path setting descriptions. [PR #13071](https://github.com/microsoft/vscode-cpptools/pull/13071)
* Update clang-format and clang-tidy from 19.1.5 to 19.1.6.
* IntelliSense parser updates.

### Bug Fixes
* Fix `compile_commands.json` no longer being used if the containing folder is deleted and recreated. [#7030](https://github.com/microsoft/vscode-cpptools/issues/7030)
* Thank you for the contribution. [@yiftahw](https://github.com/yiftahw) [PR #13032](https://github.com/microsoft/vscode-cpptools/pull/13032)
* Fix `C_Cpp.enhancedColorization` not taking effect after it's changed. [#10565](https://github.com/microsoft/vscode-cpptools/issues/10565)
* Fix changes to `files.encoding` not triggering a database reset. [#10892](https://github.com/microsoft/vscode-cpptools/issues/10892)
* Fix parameter hints interpreting `*` in a comment as markdown. [#11082](https://github.com/microsoft/vscode-cpptools/issues/11082)
* Fix an incorrect IntelliSense error when using `std::unique_ptr`. [#11979](https://github.com/microsoft/vscode-cpptools/issues/11979)
* Fix an incorrect IntelliSense error with designated initializers. [#12239](https://github.com/microsoft/vscode-cpptools/issues/12239)
* Fix handling of `koi8ru` and `koi8t` file encodings on Windows. [#12272](https://github.com/microsoft/vscode-cpptools/issues/12272)
* Fix description of `C_Cpp.preferredPathSeparator`. [#12597](https://github.com/microsoft/vscode-cpptools/issues/12597)
* Fix the IntelliSense process launching when it's disabled and the Copilot extension is used. [#12750](https://github.com/microsoft/vscode-cpptools/issues/12750), [#13058](https://github.com/microsoft/vscode-cpptools/issues/13058)
* Fix the IntelliSense mode being `macos` instead of `windows` when `_WIN32` is defined on macOS. [#13016](https://github.com/Microsoft/vscode-cpptools/issues/13016)
* Fix IntelliSense bugs when using non-UTF8 file encodings. [#13028](https://github.com/microsoft/vscode-cpptools/issues/13028), [#13044](https://github.com/microsoft/vscode-cpptools/issues/13044)
* Fix an incorrect translation for "binary operator". [#13048](https://github.com/microsoft/vscode-cpptools/issues/13048)
* Fix the "references may be missing" logging pane being shown when the `C_Cpp.loggingLevel` is `Error` or `None`. [#13066](https://github.com/microsoft/vscode-cpptools/issues/13066)
* Fix `C_Cpp.default.compilerPath` not using the `C_Cpp.preferredPathSeparator` setting when generated from the 'Select IntelliSense Configuration' command. [#13083](https://github.com/microsoft/vscode-cpptools/issues/13083)

### Version 1.23.2: December 5, 2024
### Enhancements
* Changes to how paths are internally canonicalized on Linux and macOS, avoiding file system access to improve performance and delay resolution of symbolic links. [#12924](https://github.com/microsoft/vscode-cpptools/issues/12924)
Expand All @@ -11,6 +39,7 @@
* Update clang-format and clang-tidy from 19.1.2 to 19.1.5.

### Bug Fixes
* Fix a perf regression in hover operation by using cached lexer line states. [#3126](https://github.com/microsoft/vscode-cpptools/issues/3126)
* Increase clang-format timeout from 10 seconds to 30 seconds. [#10213](https://github.com/microsoft/vscode-cpptools/issues/10213)
* Fix casing of path in include completion tooltip on Windows. [#12895](https://github.com/microsoft/vscode-cpptools/issues/12895)
* Fix pattern matching of sections in `.editorConfig` files. [#12933](https://github.com/microsoft/vscode-cpptools/issues/12933)
Expand Down
Loading
Loading