syncing with dev/sda/tree api migration

[tnaum-ms]

No description provided.

[Copilot]

Copilot reviewed 77 out of 92 changed files in this pull request and generated 2 comments.

Files not reviewed (15)

• package.json: Language not supported
• src/commands/account/copyConnectionString.ts: Evaluated as low risk
• src/commands/account/registerAccountCommands.ts: Evaluated as low risk
• src/AzureDBExperiences.ts: Evaluated as low risk
• src/commands/attachAccount/MongoConnectionStringStep.ts: Evaluated as low risk
• src/commands/attachEmulator/AttachEmulatorWizardContext.ts: Evaluated as low risk
• src/commands/attachAccount/attachAccount.ts: Evaluated as low risk
• src/commands/attachAccount/AttachAccountWizardContext.ts: Evaluated as low risk
• src/commands/attachAccount/PostgresPasswordStep.ts: Evaluated as low risk
• src/commands/attachAccount/MongoPasswordStep.ts: Evaluated as low risk
• src/commands/attachAccount/PostgresUsernameStep.ts: Evaluated as low risk
• src/commands/attachAccount/PostgresConnectionStringStep.ts: Evaluated as low risk
• src/commands/attachAccount/DocumentDBConnectionStringStep.ts: Evaluated as low risk
• src/commands/attachAccount/MongoUsernameStep.ts: Evaluated as low risk
• src/commands/ViewDatabaseOffer/viewDatabaseOffer.ts: Evaluated as low risk

Comments suppressed due to low confidence (4)

src/commands/attachAccount/PostgresExecuteStep.ts:16

• Add a check to ensure context.connectionString is defined before using it.

const connectionString = context.connectionString!;

src/commands/attachAccount/DocumentDBExecuteStep.ts:22

• The error message 'Internal error: connectionString, port, and api must be defined.' should be more specific about which value is missing.

if (api === API.Core || api === API.Table || api === API.Graph || api === API.Cassandra) {

src/commands/attachAccount/MongoExecuteStep.ts:24

• Ensure parsedCS.username and parsedCS.hosts are not undefined or empty before using them. Add a check to handle these cases.

const label = parsedCS.username + '@' + parsedCS.hosts.join(',');

src/commands/attachEmulator/ExecuteStep.ts:17

• Add checks for connectionString, port, and experience before using them to make the code more robust.

const connectionString = context.connectionString;

[tnaum-ms]

Good catch! Thanks!

[tnaum-ms]

indeed, good tip.

[tnaum-ms]

Thanks @bk201- for extracting db client calls from Mongo's tree representation. This is a fantastic step towards reducing code duplication! You’ve done an awesome job unifying code execution flows and improving the UX across the board.

Looking ahead, tree items rely on the database client to determine which children to display, and while that might seem like a natural next step for further optimization, I’d personally prefer to keep that direct connection intact :)

I also restored some lost comments.