-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpptools: use default configuration with no build type #3363
cpptools: use default configuration with no build type #3363
Conversation
53b0c57
to
0afb84c
Compare
c2076eb
to
9b9579d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! The code changes look good to me. Can you update CHANGELOG.md in the Bug Fixes section of 1.16 with brief description of your change? You can also (optionally) give yourself credit (see the other entries in the changelog).
9b9579d
to
10390f4
Compare
When configuring this extension with a CMakePresets.json, with a CMakeCache.txt that doesn't define a CMAKE_BUILD_TYPE, the intelliSense configuration was not passed to vscode-cpptools. However, this is a valid CMake configuration which should use the toolchain's default configuration. Building through the extension did work. The codeModelContent configuration was rejected because it's name (""), didn't match activeBuildTypeVariant which was null. This patch accepts an unnamed configurations in the case where no active build type variant is set. The CHANGELOG was updated.
10390f4
to
12fd529
Compare
Thanks for your review! I've updated the CHANGELOG. |
@microsoft-github-policy-service agree company="Savoir-faire Linux" |
Bypassing failing Windows CI to merge (#3365). |
@deribaucourt This change will be available on our public pre-release channel in the VS Code Marketplace within 24 hours and will be included in the upcoming official 1.16 release. Thanks! |
See related Issue's description: #3355
Change description in the commit message:
This change addresses item #3355
This changes visible behavior
The following changes are proposed:
CMAKE_BUILD_TYPE
is empty