Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize drive letter on windows for presets expanision #2665

Merged
merged 6 commits into from
Sep 23, 2022

Conversation

Danielmelody
Copy link
Contributor

@Danielmelody Danielmelody commented Aug 2, 2022

This changes is a workaround for microsoft/vscode#156781

The following changes are proposed:

When expanding macros for CmakePresets.json on windows, the drive letter will now be re-normalized to uppercase.

The purpose of this change

When access workspaceFolder by uri, VScode normalize drive letter on windows to lowercase for historical reason. This behavior will cause all expanded path start with a lowercase drive letter, while Visual Studio, at the same time, expanding it as uppercase. If a user is switching vscode and Visual Studio, they would have to regenerate cmake cache as cmake count all those paths as a different variables.

Other Notes/Information

@Danielmelody Danielmelody changed the title Nromalize drive letter on windows for presets expanision Normalize drive letter on windows for presets expanision Aug 2, 2022
@bobbrow
Copy link
Member

bobbrow commented Aug 2, 2022

Thanks for the pull request. We'll do a bit of research and make sure this doesn't have any unintended consequences before we merge this in.

@Danielmelody
Copy link
Contributor Author

Any progress?

@bobbrow
Copy link
Member

bobbrow commented Aug 15, 2022

Sorry for the silence. We've been finishing up the remaining tasks for the 1.12 release which has taken a bit longer than expected. We're almost done and then we will come back to the outstanding PR's.

@bobbrow bobbrow added this to the On Deck milestone Aug 15, 2022
@bobbrow bobbrow added this to In Progress in 1.13 via automation Aug 15, 2022
@bobbrow bobbrow moved this from In Progress to Pull Requests in 1.13 Aug 31, 2022
@Danielmelody
Copy link
Contributor Author

@bobbrow I 'm not quite understand the failing CI result, is there any thing I need to do?

@bobbrow
Copy link
Member

bobbrow commented Sep 16, 2022

@bobbrow I 'm not quite understand the failing CI result, is there any thing I need to do?

Something changed in CI to make that test flaky. We'll rerun the test until it clears out. You don't need to worry about it.

src/presetsController.ts Outdated Show resolved Hide resolved
@bobbrow bobbrow merged commit 07fd17c into microsoft:main Sep 23, 2022
1.13 automation moved this from Pull Requests to Done Sep 23, 2022
@bobbrow bobbrow modified the milestones: On Deck, 1.13 Sep 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
1.13
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants