Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "cmake.ignoreCMakeListsMissing" (#2532) #2537

Merged
merged 7 commits into from
May 11, 2022

Conversation

ilg-ul
Copy link
Contributor

@ilg-ul ilg-ul commented May 10, 2022

This change addresses item #2532

This changes visible behaviour

The following changes are proposed:

  • add the boolean cmake.ignoreCMakeListsMissing option at the end of the list
  • add the boolean ignoreCMakeListsMissing member to the ExtensionConfigurationSettings interface
  • if this option is set, skip asking the user what to do if CMakeLists.txt is not found in the project root

Other Notes/Information

  • the option is defined in the resource scope, but it is only checked in the this.workspaceContext.config
  • the option has an even emitter, but for now it is not used
  • there are no i18n messages

@ghost
Copy link

ghost commented May 10, 2022

CLA assistant check
All CLA requirements met.

src/cmakeTools.ts Outdated Show resolved Hide resolved
package.nls.json Outdated Show resolved Hide resolved
src/cmakeTools.ts Outdated Show resolved Hide resolved
@ilg-ul
Copy link
Contributor Author

ilg-ul commented May 10, 2022

@bobbrow, what do you think about adding "cmake.ignoreCMakeListsMissing": true to the .vscode/settings.json?

@ilg-ul ilg-ul requested a review from bobbrow May 10, 2022 19:09
@bobbrow
Copy link
Member

bobbrow commented May 10, 2022

@bobbrow, what do you think about adding "cmake.ignoreCMakeListsMissing": true to the .vscode/settings.json?

cmake.sourceDirectory is already set, so that shouldn't be necessary for this project.

@bobbrow bobbrow added this to Pull Requests in 1.11 via automation May 10, 2022
@bobbrow bobbrow added this to the 1.11.0 milestone May 10, 2022
@bobbrow
Copy link
Member

bobbrow commented May 10, 2022

Oh, actually, one last thing I forgot. Could you add a line in the CHANGELOG.md in the "Improvements" section to mention your change and give yourself credit? Follow the examples in the file.

@ilg-ul
Copy link
Contributor Author

ilg-ul commented May 10, 2022

... CHANGELOG.md

Done.

@ilg-ul ilg-ul changed the title add "cmake.ignoreCMakeListsMissing" (#2532) Add "cmake.ignoreCMakeListsMissing" (#2532) May 10, 2022
@bobbrow bobbrow enabled auto-merge (squash) May 11, 2022 00:12
@bobbrow bobbrow merged commit e37a1a5 into microsoft:main May 11, 2022
1.11 automation moved this from Pull Requests to Done May 11, 2022
@ilg-ul
Copy link
Contributor Author

ilg-ul commented May 11, 2022

Great!

Thank you for your help!

@ilg-ul ilg-ul deleted the ignoreCMakeListsMissing branch May 11, 2022 05:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
1.11
Done
Development

Successfully merging this pull request may close these issues.

Could we add an option to disable "CMakeLists.txt was not found in the root of the folder..."?
2 participants