Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial/full activation mode and multi root. Disable automatic configures. #1295
Partial/full activation mode and multi root. Disable automatic configures. #1295
Changes from 2 commits
eee243e
159e0e6
3c27b40
27bee85
16ac13c
1635e89
34c100b
dd39230
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this pattern confusing. You need to set
_enableFullFeatureSetOnWorkspace
tofalse
outside of this method becausefullFeatureSet
can't change the true to false. Is there a reason you can't just take the value offullFeatureSet
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand but let me explain more and you can follow up with rephrasing the above if needed.
Each folder of the multi root workspace may have different values for fullFeatureSet that need to stay persisted in the stage of each of them. Once I apply any OR to them, we'll persist the wrong value. I was thinking that we persist the exact state for each folder: full or partial activation, while partial activation means the "ignore" button has been pressed already and full means the ignore wasn't pressed. And calculate based on them a final decision for the whole multi root workspace. And yes, once true it can't get back to false if we don't have the extra variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we ever need to turn support off? I'm wondering if we should just leave the full feature set enabled once it's been enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you remove the state that would make CMake Tools enable the full feature set, then you would need to reload the window at that point to disable it. I would be fine with that behavior.