Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kit env variables are not getting updated #2364

Closed
elahehrashedi opened this issue Feb 7, 2022 · 0 comments · Fixed by #2434
Closed

Kit env variables are not getting updated #2364

elahehrashedi opened this issue Feb 7, 2022 · 0 comments · Fixed by #2434
Assignees
@elahehrashedi
Labels
bug a bug in the product Feature: kits fixed (release pending) fixed in pre-release and is pending official release
Projects
1.11
Milestone
1.11

Comments

@elahehrashedi
Copy link
Contributor

When changing the kit, the env variables defined in "environmentVariables" and "environmentSetupScript" defined in cmake-kits.json are not getting updated.
@elahehrashedi elahehrashedi added bug a bug in the product Feature: kits labels Feb 7, 2022
@elahehrashedi elahehrashedi added this to the On Deck milestone Feb 7, 2022
@elahehrashedi elahehrashedi mentioned this issue Feb 7, 2022
Closed
lygstate added a commit to lygstate/vscode-cmake-tools that referenced this issue Feb 8, 2022
@lygstate
Revise effectiveKitEnvironment to fixes microsoft#2354 and microsoft#…
d1e8b80 
…2364

Signed-off-by: Yonggang Luo <[email protected]>
lygstate added a commit to lygstate/vscode-cmake-tools that referenced this issue Feb 9, 2022
@lygstate
Revise effectiveKitEnvironment to fixes microsoft#2354 and microsoft#…
da34bb5 
…2364

Signed-off-by: Yonggang Luo <[email protected]>
@lygstate lygstate mentioned this issue Feb 12, 2022
Merged
lygstate added a commit to lygstate/vscode-cmake-tools that referenced this issue Feb 15, 2022
@lygstate
Revise effectiveKitEnvironment to fixes microsoft#2354 and microsoft#…
e039a39 
…2364

Signed-off-by: Yonggang Luo <[email protected]>
bobbrow pushed a commit that referenced this issue Feb 16, 2022
@lygstate
Revise effectiveKitEnvironment to fixes #2354 and #2364 (#2360)
1c75ad6
@bobbrow bobbrow added this to Triage in 1.11 via automation Mar 1, 2022
@bobbrow bobbrow moved this from Triage to To do in 1.11 Mar 1, 2022
@elahehrashedi elahehrashedi moved this from To do to In progress in 1.11 Mar 17, 2022
@elahehrashedi elahehrashedi mentioned this issue Mar 17, 2022
Merged
@elahehrashedi elahehrashedi modified the milestones: On Deck, 1.11.0 Mar 18, 2022
1.11 automation moved this from In progress to Done Apr 4, 2022
@bobbrow bobbrow added the fixed (release pending) fixed in pre-release and is pending official release label Apr 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@elahehrashedi elahehrashedi

Labels
bug a bug in the product Feature: kits fixed (release pending) fixed in pre-release and is pending official release
Projects
No open projects
1.11
Done
Milestone
1.11
Development

Successfully merging a pull request may close this issue.

disposing the terminal when env variables are getting updated microsoft/vscode-cmake-tools
2 participants
@bobbrow @elahehrashedi