Skip to content

Pin System.Memory to 4.5.5 to fix VS 2022 analyzer load failure #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andrew Arnott (AArnott) merged 3 commits into from
Jul 8, 2026
Merged

Pin System.Memory to 4.5.5 to fix VS 2022 analyzer load failure #1612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05439fa
Initial plan
Copilot Jul 8, 2026
d0e8b43
Pin System.Memory to 4.5.5 to match VS 2022 runtime
Copilot Jul 8, 2026
81a11e4
Use IsAnalyzerProject pattern to pin System.Memory for analyzer projects
Copilot Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@
<PackageVersion Include="Xunit.Combinatorial" Version="2.0.24" />
<PackageVersion Include="Xunit.StaFact" Version="3.0.13" />
</ItemGroup>
<!-- Analyzer projects must use versions of these packages that the VS host provides.
Comment thread
AArnott marked this conversation as resolved.
Resolved
Pinning here ensures a dependency update bot won't silently upgrade them to versions VS can't load. -->
<ItemGroup Condition="'$(IsAnalyzerProject)'=='true'">
<PackageVersion Update="System.Memory" Version="4.5.5" />
</ItemGroup>
Comment thread
AArnott marked this conversation as resolved.
Resolved
<ItemGroup Label="Library.Template">
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.8.0" />
<PackageVersion Include="Microsoft.Testing.Extensions.CrashDump" Version="$(MicrosoftTestingPlatformVersion)" />
Expand Down
7 changes: 7 additions & 0 deletions src/Analyzers.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<!-- This is set so that Directory.Packages.props can apply version overrides specific to analyzer projects. -->
<IsAnalyzerProject>true</IsAnalyzerProject>
</PropertyGroup>
</Project>
1 change: 1 addition & 0 deletions ...tudio.Threading.Analyzers.CSharp/Microsoft.VisualStudio.Threading.Analyzers.CSharp.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="..\Analyzers.props" />
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<RootNamespace>Microsoft.VisualStudio.Threading.Analyzers</RootNamespace>
Expand Down
1 change: 1 addition & 0 deletions ...Threading.Analyzers.CodeFixes/Microsoft.VisualStudio.Threading.Analyzers.CodeFixes.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="..\Analyzers.props" />
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<RootNamespace>Microsoft.VisualStudio.Threading.Analyzers</RootNamespace>
Expand Down
1 change: 1 addition & 0 deletions ...ading.Analyzers.VisualBasic/Microsoft.VisualStudio.Threading.Analyzers.VisualBasic.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="..\Analyzers.props" />
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<RootNamespace>Microsoft.VisualStudio.Threading.Analyzers</RootNamespace>
Expand Down
1 change: 1 addition & 0 deletions ...rosoft.VisualStudio.Threading.Analyzers/Microsoft.VisualStudio.Threading.Analyzers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
<Import Project="..\Analyzers.props" />
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
Expand Down
Loading