Don't package reference inbox assemblies on .NETCoreApp #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft.Win32.Registry got added to the .NETCoreApp shared framework with .NET 5. System.Threading.Tasks.Extensions has been part of the shared framework since I believe .NET Core 2.0. Microsoft.Bcl.AsyncInterfaces since .NET Core 2.1. Don't reference these packages on .NETCoreApp to reduce the dependency graph and with that potential CVEs / CG warnings.
AArnott
approved these changes
Jan 4, 2024
|
@ViktorHofer Is there any reason we should take steps to ensure this goes into 17.9? Or would 17.10 be sufficient? |
|
Responded offline as well. 17.10 is fine, there's no time pressure at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't reference these packages on .NETCoreApp to reduce the dependency graph and with that potential CVEs / CG warnings.