Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use precise assembly version for analyzers project #1266

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Dec 12, 2023

This removes an MSBuild property that makes version calculating happen only once per build, under the (incorrect) assumption that only one version.json file exists in this repo. But the analyzers project has a unique one, and this msbuild property was causing that to be ignored.

See also microsoft/vs-mef#437 for a similar bug and fix.

This removes an MSBuild property that makes version calculating happen only once per build, under the (incorrect) assumption that only one version.json file exists in this repo. But the analyzers project has a unique one, and this msbuild property was causing that to be ignored.
@AArnott AArnott added this to the v17.8 milestone Dec 12, 2023
@AArnott AArnott self-assigned this Dec 12, 2023
@AArnott
Copy link
Member Author

AArnott commented Jan 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AArnott AArnott enabled auto-merge January 5, 2024 17:13
@AArnott AArnott merged commit 10e3ca8 into microsoft:v17.8 Jan 5, 2024
6 checks passed
@AArnott AArnott deleted the preciseAnalyzerVersion branch January 5, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants