Expose a property on whether JoinableTaskContext has any JTF blocking calls on the main thread #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calls on the main thread
AArnott
requested changes
Apr 27, 2022
Member
AArnott
left a comment
AArnott
left a comment
There was a problem hiding this comment.
Thanks for preparing this. I think you're close.
test/Microsoft.VisualStudio.Threading.Tests/JoinableTaskContextTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.VisualStudio.Threading.Tests/JoinableTaskContextTests.cs
Outdated
Show resolved
Hide resolved
AArnott
requested changes
Apr 29, 2022
test/Microsoft.VisualStudio.Threading.Tests/JoinableTaskContextTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.VisualStudio.Threading.Tests/JoinableTaskContextTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.VisualStudio.Threading.Tests/JoinableTaskContextTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.VisualStudio.Threading.Tests/JoinableTaskContextTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.VisualStudio.Threading.Tests/JoinableTaskContextTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.VisualStudio.Threading.Tests/JoinableTaskContextTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.VisualStudio.Threading.Tests/JoinableTaskContextTests.cs
Outdated
Show resolved
Hide resolved
AArnott
approved these changes
May 2, 2022
AArnott
added a commit
to AArnott/vs-threading
that referenced
this pull request
Jun 15, 2022
…blocking calls on the main thread (microsoft#1026)" This reverts commit 553c404.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have IsMainThreadBlocked and IsMainThreadMaybeBlocked. Both APIs indicate whether the main thread is blocked by the caller.
Sometimes we need to know whether the main thread is blocked by anyone using JoinableTaskFactory's several blocked APIs. This change exposes that property.