Skip to content

Conversation

@lifengl
Copy link
Member

@lifengl lifengl commented Apr 7, 2022

This PR is to improve performance of JoinAsync when a cancellation token is not being used.

The reason behind this is JoinAsync will only complete when the task being waited is completed. A completed JoinableTask will remove itself from the graph, so we don't need chain the task inside JoinAsync to clean up the new dependency.

It is more efficiently to do that:
1, removing dependency will need get into the global lock, which is a contention point of the product
2, removing the completed task will cut all dependencies in one operation, which is much efficient than removing dependencies one by one.

This will allow us not to have any new async state machine in that case, and cut off some unnecessary task continuation in the AsyncLazy, when GetValueAsync is called without a cancellation token.

@lifengl lifengl requested a review from AArnott April 7, 2022 01:55
lifengl and others added 2 commits April 7, 2022 11:19
Also touch-up code comments and modify syntax to make it consistent across the two methods.
Copy link
Member

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I push a minor change of my own. Please review it before merging, @lifengl.

@lifengl
Copy link
Member Author

lifengl commented Apr 8, 2022

makes sense. thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants