Merge pull request #303 from AArnott/optprof_fixes

Add OptProf.targets and comments to help onboarding

azure-pipelines/build.yml

@@ -4,6 +4,12 @@ parameters:
 ##### Feel free to adjust their default value as needed.
 
 # Whether this repo uses OptProf to optimize the built binaries.
+# When enabling this, be sure to update these files:
+# - OptProf.targets: InstallationPath and match TestCase selection with what's in the VS repo.
+# - The project file(s) for the libraries to optimize must import OptProf.targets (for multi-targeted projects, only import it for ONE target).
+# - OptProf.yml: Search for LibraryName (or your library's name) and verify that those names are appropriate.
+# - OptProf_part2.yml: Search for LibraryName (or your library's name) and verify that those names are appropriate.
+# and create pipelines for OptProf.yml, OptProf_part2.yml
 - name: EnableOptProf
   type: boolean
   default: false

azure-pipelines/microbuild.after.yml

@@ -29,7 +29,6 @@ steps:
       usePat: true
     displayName: 📢 Publish to Artifact Services - ProfilingInputs
     condition: and(succeeded(), ne(variables['Build.Reason'], 'PullRequest'))
-    continueOnError: true
 
   - task: PublishBuildArtifacts@1
     inputs:

src/OptProf.targets

@@ -0,0 +1,17 @@
+<Project>
+  <ItemGroup>
+    <OptProf Include="$(TargetPath)">
+      <Technology>IBC</Technology>
+      <InstallationPath>Common7\IDE\PrivateAssemblies\$(TargetFileName)</InstallationPath>
+      <InstrumentationArguments>/ExeConfig:"%VisualStudio.InstallationUnderTest.Path%\Common7\IDE\vsn.exe"</InstrumentationArguments>
+      <Scenarios>
+        <TestContainer Name="VSPE" Repository="VS">
+          <!-- When adding to this list, be sure to also add to VS repo too (e.g. https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/196226) -->
+          <TestCase FullyQualifiedName="VSPE.OptProfTests.vs_env_startup_devenv" />
+          <TestCase FullyQualifiedName="VSPE.OptProfTests.vs_perf_DesignTime_solution_loadclose_cs_picasso" />
+          <TestCase FullyQualifiedName="VSPE.OptProfTests.vs_ddbvtqa_vbwin" />
+        </TestContainer>
+      </Scenarios>
+    </OptProf>
+  </ItemGroup>
+</Project>