Fix perf regression in testing for RPC marshalable objects#1329
Merged
Fix perf regression in testing for RPC marshalable objects#1329
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a performance regression in RPC marshalable object testing that was introduced by recent refactoring. The key issue was that the code no longer broke out early when testing non-interface types, causing unnecessary work. The fix also adds caching for redundant attribute checks on interface types.
Key Changes:
- Modified
TryGetMarshalOptionsForTypeHelperto returnbool?instead ofboolto distinguish between "definitely not marshalable" (false), "definitely marshalable" (true), and "unknown, needs more checking" (null) - Added
RpcMarshalableAttributeCacheto cacheRpcMarshalableAttributelookups and reduce redundant reflection calls - Introduced
TryGetRpcMarshalableAttributehelper method to centralize and cache attribute retrieval
Member
Author
|
This is being validated for effectiveness with this validation insertion. |
matteo-prosperi
approved these changes
Oct 21, 2025
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some recent refactoring inadvertently caused RPC marshalable object testing to not break out early when the type is not an interface.
In this change, I correct that mistake. I also cache redundant attribute checks for interface types.
As reported in devdiv-2575202