Add RpcTargetMetadata generation from ITypeShape#1251
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for generating RpcTargetMetadata from ITypeShape objects, enabling RPC target creation for types with PolyType shapes. This functionality is essential for supporting trimmed applications and NativeAOT scenarios where dynamic runtime reflection is not available.
Key changes:
- Adds new
FromShapemethods to generate RPC metadata from type shapes - Refactors
TargetMethodMetadatato support shape-based construction - Updates method references from
MethodtoMethodInfofor clarity
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| RpcTargetMetadata.cs | Core implementation of shape-based metadata generation with new FromShape methods |
| RpcTargetMetadataTests.cs | Test coverage for the new shape-based functionality |
| TargetMethod.cs | Updates method property references to use new MethodInfo property name |
| RpcTargetInfo.cs | Updates method creation call to pass null shape parameter |
| ProxyGeneration.cs | Updates method property reference to use new MethodInfo property name |
| PublicAPI.*.txt | API surface updates for the new methods and property changes |
| StreamJsonRpc.csproj | Enables format methods for embedded resources |
| Resources.resx | Adds error message for missing AttributeProvider |
| Directory.Packages.props | Adds PolyType package dependency |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
ekoppel
approved these changes
Aug 18, 2025
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for creating RPC targets for any type for which a PolyType shape is available, such that it's safe in a trimmed app without a dynamic runtime (e.g. NativeAOT).
This is an important prerequisite for the
NerdbankMessagePackFormatterto be able to support RPC general marshable objects, as they become RPC targets in an almost unpredictable fashion.