Source generate proxies for RpcMarshalable interfaces#1246
Merged
Conversation
This might have been as simple as source generating proxies for the additional attribute (changes in ProxyGenerator.cs), except that marshalable interfaces exercise several patterns that our standard RPC interface tests didn't cover, so several bugs had to be fixed.
There was a problem hiding this comment.
Pull Request Overview
This PR adds source generation support for interfaces marked with the RpcMarshalable attribute, extending the existing proxy generation capability beyond just JsonRpcContract interfaces. The implementation fixes several bugs discovered during development related to patterns that marshalable interfaces exercise.
Key changes:
- Added RpcMarshalable interfaces to proxy generation alongside JsonRpcContract interfaces
- Enhanced proxy models to handle generic interfaces and invalid member detection
- Fixed bugs in interface member handling and proxy generation patterns
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/StreamJsonRpc.Analyzers/ProxyGenerator.cs |
Added RpcMarshalable attribute provider and combined it with existing contract provider |
src/StreamJsonRpc.Analyzers/GeneratorModels/ProxyModel.cs |
Enhanced to support generic types and detect invalid interfaces with unsupported members |
src/StreamJsonRpc.Analyzers/GeneratorModels/InterfaceModel.cs |
Refactored to track unsupported member types and improved member categorization |
src/StreamJsonRpc.Analyzers/GeneratorModels/EventModel.cs |
Fixed display format for event types |
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs |
Updated collection initialization syntax |
test/ files |
Added comprehensive test coverage for RpcMarshalable proxy generation scenarios |
murphymcquet-msft
approved these changes
Aug 12, 2025
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might have been as simple as source generating proxies for the additional attribute (changes in ProxyGenerator.cs), except that marshalable interfaces exercise several patterns that our standard RPC interface tests didn't cover, so several bugs had to be fixed.