Stop intercepting Attach calls within StreamJsonRpc itself#1241
Merged
Conversation
This was causing runtime regressions in existing callers that were using the older APIs.
There was a problem hiding this comment.
Pull Request Overview
This PR disables interceptors within the StreamJsonRpc library itself to prevent runtime regressions in existing callers using older APIs. The change ensures that the library's own unsafe APIs are not automatically rewritten to call safe APIs, which could cause unexpected failures when callers aren't prepared for NativeAOT safety restrictions.
Key changes:
- Disabled interceptors for the StreamJsonRpc library project itself
- Added test to verify no interceptors are generated within the library
- Made interceptor enablement conditional in analyzer targets
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/StreamJsonRpc/StreamJsonRpc.csproj | Explicitly disables interceptors for the main library |
| src/AnalyzerUser.targets | Makes interceptor enablement conditional to allow overrides |
| test/StreamJsonRpc.Tests/ArchitectureTests.cs | Adds test to verify no interceptors exist in the assembly |
| test/StreamJsonRpc.Analyzer.Tests/ProxyGeneratorTests.cs | Documents existing interceptor test scenarios |
javierdlg
approved these changes
Aug 8, 2025
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing runtime regressions in existing callers that were using the older APIs.
The interceptor was designed for external assemblies. Not StreamJsonRpc itself.