Skip to content

Expose MessageFormatterEnumerableTracker.EnumeratorResults as public #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AArnott merged 2 commits into from
Jun 17, 2025
Merged

Expose MessageFormatterEnumerableTracker.EnumeratorResults as public #1206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe6ce23
Expose MessageFormatterEnumerableTracker.EnumeratorResults as public
eerhardt Jun 17, 2025
6523925
Update src/StreamJsonRpc/Reflection/MessageFormatterEnumerableTracker.cs
eerhardt Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions src/StreamJsonRpc/Reflection/MessageFormatterEnumerableTracker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using System.Buffers;
using System.Collections.Immutable;
using System.ComponentModel;
using System.Reflection;
using System.Runtime.Serialization;
using System.Threading.Tasks.Dataflow;
Expand Down Expand Up @@ -218,6 +219,29 @@ private void CleanUpResources(RequestId outboundRequestId)
}
}

/// <summary>
/// A slice of results from an <see cref="IAsyncEnumerable{T}"/>.
/// </summary>
/// <typeparam name="T">The type of element in the enumeration.</typeparam>
[DataContract]
[EditorBrowsable(EditorBrowsableState.Never)]
public sealed class EnumeratorResults<T>
{
/// <summary>
/// Gets the slice of values in this segment.
/// </summary>
[DataMember(Name = ValuesPropertyName, Order = 0)]
[STJ.JsonPropertyName(ValuesPropertyName), STJ.JsonPropertyOrder(0)]
public IReadOnlyList<T>? Values { get; init; }

/// <summary>
/// Gets a value indicating whether this is definitely the last slice.
/// </summary>
[DataMember(Name = FinishedPropertyName, Order = 1)]
[STJ.JsonPropertyName(FinishedPropertyName), STJ.JsonPropertyOrder(1)]
public bool Finished { get; init; }
}

private class GeneratingEnumeratorTracker<T> : IGeneratingEnumeratorTracker
{
private readonly IAsyncEnumerator<T> enumerator;
Expand Down Expand Up @@ -525,16 +549,4 @@ private static void Write(IBufferWriter<T> writer, IReadOnlyList<T> values)
}
}
}

[DataContract]
private class EnumeratorResults<T>
{
[DataMember(Name = ValuesPropertyName, Order = 0)]
[STJ.JsonPropertyName(ValuesPropertyName), STJ.JsonPropertyOrder(0)]
public IReadOnlyList<T>? Values { get; set; }

[DataMember(Name = FinishedPropertyName, Order = 1)]
[STJ.JsonPropertyName(FinishedPropertyName), STJ.JsonPropertyOrder(1)]
public bool Finished { get; set; }
}
}
8 changes: 7 additions & 1 deletion src/StreamJsonRpc/net8.0/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
StreamJsonRpc.JsonRpc.Attach(System.ReadOnlySpan<System.Type!> interfaceTypes, StreamJsonRpc.JsonRpcProxyOptions? options) -> object!
StreamJsonRpc.JsonRpc.Attach(System.ReadOnlySpan<System.Type!> interfaceTypes, StreamJsonRpc.JsonRpcProxyOptions? options) -> object!
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.EnumeratorResults() -> void
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Finished.get -> bool
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Finished.init -> void
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Values.get -> System.Collections.Generic.IReadOnlyList<T>?
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Values.init -> void
8 changes: 7 additions & 1 deletion src/StreamJsonRpc/netstandard2.0/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
StreamJsonRpc.JsonRpc.Attach(System.ReadOnlySpan<System.Type!> interfaceTypes, StreamJsonRpc.JsonRpcProxyOptions? options) -> object!
StreamJsonRpc.JsonRpc.Attach(System.ReadOnlySpan<System.Type!> interfaceTypes, StreamJsonRpc.JsonRpcProxyOptions? options) -> object!
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.EnumeratorResults() -> void
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Finished.get -> bool
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Finished.init -> void
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Values.get -> System.Collections.Generic.IReadOnlyList<T>?
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Values.init -> void
8 changes: 7 additions & 1 deletion src/StreamJsonRpc/netstandard2.1/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
StreamJsonRpc.JsonRpc.Attach(System.ReadOnlySpan<System.Type!> interfaceTypes, StreamJsonRpc.JsonRpcProxyOptions? options) -> object!
StreamJsonRpc.JsonRpc.Attach(System.ReadOnlySpan<System.Type!> interfaceTypes, StreamJsonRpc.JsonRpcProxyOptions? options) -> object!
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.EnumeratorResults() -> void
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Finished.get -> bool
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Finished.init -> void
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Values.get -> System.Collections.Generic.IReadOnlyList<T>?
StreamJsonRpc.Reflection.MessageFormatterEnumerableTracker.EnumeratorResults<T>.Values.init -> void