Refactor reflection usage to only reflection against the one method#1199
Merged
AArnott merged 1 commit intomicrosoft:mainfrom Jun 13, 2025
Merged
Refactor reflection usage to only reflection against the one method#1199AArnott merged 1 commit intomicrosoft:mainfrom
AArnott merged 1 commit intomicrosoft:mainfrom
Conversation
Reflecting on all methods on the Type preserves all methods on the Type, which causes more code to be kept than is actually used in the app. Instead, use a reflection pattern that targets the specific method being reflected on.
AArnott
approved these changes
Jun 13, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflecting on all methods on the Type preserves all methods on the Type, which causes more code to be kept than is actually used in the app.
Instead, use a reflection pattern that targets the specific method being reflected on.
With the current code, all methods on
JsonRpcare being preserved, causing things like Newtonsoft.Json to be kept in the app even though it is not used.cc @AArnott