Fix package restore in init.ps1#1
Merged
IlyaBiryukov merged 1 commit intomasterfrom Oct 15, 2016
Merged
Conversation
|
Hi @AArnott, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Member
Author
|
Thanks. |
AArnott
referenced
this pull request
in AArnott/vs-streamjsonrpc
Oct 29, 2020
This was allocating 8012 objects in a perf trace I took (the #1 most allocated object). It should have been 0.
AArnott
referenced
this pull request
in AArnott/vs-streamjsonrpc
Oct 29, 2020
This was allocating 8012 objects in a perf trace I took (the #1 most allocated object). It should have been 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When restoring packages for a
project.jsondirectly, as init.ps1 will do for nuproj projects, the config file is not automatically found by nuget.exe. This forces it to consider that, which lets the package restore succeed since the packages come from sources other than nuget.org.