[python3] Modernize port + added --enable-shared#9978
Merged
strega-nil merged 1 commit intomicrosoft:masterfrom Mar 10, 2020
Merged
[python3] Modernize port + added --enable-shared#9978strega-nil merged 1 commit intomicrosoft:masterfrom
strega-nil merged 1 commit intomicrosoft:masterfrom
Conversation
NancyLi1013
suggested changes
Feb 10, 2020
theblackunknown
force-pushed
the
integration-python3
branch
2 times, most recently
from
3febd99 to
d62b012
Compare
JackBoosY
suggested changes
Feb 13, 2020
theblackunknown
force-pushed
the
integration-python3
branch
from
d62b012 to
4a96311
Compare
JackBoosY
approved these changes
Feb 15, 2020
Contributor
|
Will rerun ci test after #10051 merged. |
Contributor
Author
|
Thank @JackBoosY ! |
Contributor
|
/azp run |
JackBoosY
added
the
info:needs-maintainer-attention
Contributor
|
@strega-nil Could you please review and merge this PR? |
Contributor
|
Thanks @theblackunknown :D |
Toxe
pushed a commit
to Toxe/vcpkg
that referenced
this pull request
Mar 11, 2020
Toxe
added a commit
to Toxe/vcpkg
that referenced
this pull request
Mar 11, 2020
)" This reverts commit d5db787.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize port + added Feature to request to build shared libraries
What does your PR fix?
No logged issue, but the problem arose when trying to use this port to build Python extensions on Linux : shared library are needed, even when we are using VCPKG_LIBRARY_LINKAGE as static
Which triplets are supported/not supported? Have you updated the CI baseline?
No CI update, works at least with windows & linux
Does your PR follow the maintainer guide?
It should !